docs: record the repo-wide gate/fill description sweep (#82) - #83
Merged
Conversation
#78's guard scanned only the two report modules it had just fixed, so six live instances of the same defect -- qt/config.py plus five I5b/c/d/e/f config YAMLs -- were unreachable by it in principle. The YAMLs are what an operator reads before enabling price_limit_check, a higher-stakes readership than a docstring. Widening the scan immediately found six more of a related kind: the FILL price descriptions ('the first valid 1min close in [14:51, 14:56:59]') that PR #75 also moved to the bar VWAP. Twelve sites total. The rule worth keeping is recorded with it: a guard scoped to the files you have already fixed can only ever confirm what you already know. Quality-gate line re-measured on main @ f432dc5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Records PR #82 in the canonical progress file, plus the quality-gate line re-measured on
main@f432dc5.The entry carries the rule the episode established, which is the part worth keeping:
Widening the scan past the two modules #78 had fixed found six more stale sites of a related kind — the fill-price descriptions PR #75 also moved to the bar VWAP. Twelve total: seven describing the gate, five describing the fill.
Also recorded: the two restatements that survive by necessity (import cycle), what was deliberately not swept and why (the daily tradability filter genuinely compares a raw daily close — a careless sweep would have replaced a true statement with a false one), the guard's honest scope (catches literal 'close', not reworded synonyms — seven demonstrated escapes), and the reviewer's independent re-derivation (12 pre-fix hits / 0 post-fix, line numbers matching).
Gates:
pytest1776 passed ·ruffclean · 31/31 configs · phase0ic_mean=0.9600, annual_return=0.8408